-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(RHINENG-3032, RHINENG-5932): Upgrade to React 18 & PatternFly 5 #2141
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d8789c3
chore: Upgrade React and PF with other affected packages
gkarat aba4439
chore: Running pf-codemods fix
gkarat fe8be0e
chore: Wrap icons
gkarat fd57f59
chore(TopBar): Rewrite Dropdown
gkarat 6778b0a
chore: Install jest-environment-jsdom
gkarat 22f36d8
chore: Add missing conditional filter type
gkarat 3377253
chore: Update SkeletonTable columns prop
gkarat 391425e
chore: Fix the jest warning regarding testUrl
gkarat 83c0b73
chore: Fix "import statement" issue with Jest
gkarat e8c6af0
chore(GroupDetailHeader): Rebuild Dropdown
gkarat 7492ff2
chore: Run classnames fix
gkarat c65b184
chore: Update test snapshots
gkarat 01234a9
chore: Update hook tests
gkarat 270c65a
chore: Update SkeletonTable props
gkarat f57c366
chore: Fix the rest of unit tests after migration
gkarat 71f3b2c
chore: Use cypress/react18, tweak toggle text selectors
gkarat 07fca42
chore(InventoryTable): Provide count to PrimaryToolbar
gkarat 49542b4
chore: Temporarily disable cypress tests in Travis CI
gkarat ee15e39
chore(ActionDropdownItem): Fix and preserve dropdown style
gkarat 59db043
chore(SearchableGroupFilter): Keep checkboxes and styling
gkarat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,7 @@ module.exports = { | |
globals: { | ||
IS_DEV: 'readonly', | ||
}, | ||
rules: { | ||
'rulesdir/forbid-pf-relative-imports': 'off', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have still some cypress tests. Should we keep cypress tests running in travis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be re-enabled in #2146