Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(InventoryTable): Deprecate unused actions #2128

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Dec 20, 2023

This removes some actions definitions and action creators that are not used in Inventory and other applications.

@gkarat gkarat self-assigned this Dec 20, 2023
@gkarat gkarat requested a review from a team as a code owner December 20, 2023 17:06
@gkarat gkarat force-pushed the refactor-inventory-table branch from 873931e to 0f32788 Compare December 20, 2023 17:32
@gkarat gkarat marked this pull request as draft December 20, 2023 17:32
@gkarat gkarat changed the title refactor(InventoryTable): Deprecate unused actions WIP: refactor(InventoryTable): Deprecate unused actions Dec 20, 2023
@gkarat gkarat changed the title WIP: refactor(InventoryTable): Deprecate unused actions refactor(InventoryTable): Deprecate unused actions Dec 21, 2023
@gkarat gkarat marked this pull request as ready for review December 21, 2023 13:14
@gkarat
Copy link
Contributor Author

gkarat commented Dec 21, 2023

This is ready for review

@gkarat
Copy link
Contributor Author

gkarat commented Dec 21, 2023

/retest

Copy link
Member

@LiorKGOW LiorKGOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked and everything seems fine in my local environment after these changes, I agree we should remove those unused actions

Thank you @gkarat !

@gkarat
Copy link
Contributor Author

gkarat commented Jan 2, 2024

/retest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a18b479) 57.64% compared to head (c993d9e) 57.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2128      +/-   ##
==========================================
- Coverage   57.64%   57.54%   -0.11%     
==========================================
  Files         193      193              
  Lines        6198     6190       -8     
  Branches     1718     1718              
==========================================
- Hits         3573     3562      -11     
- Misses       2625     2628       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkarat
Copy link
Contributor Author

gkarat commented Jan 3, 2024

/retest

@gkarat gkarat merged commit e19520c into RedHatInsights:master Jan 4, 2024
1 of 2 checks passed
@gkarat gkarat deleted the refactor-inventory-table branch January 4, 2024 11:14
@gkarat
Copy link
Contributor Author

gkarat commented Jan 4, 2024

🎉 This PR is included in version 1.62.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants