test: Add tests for remove hosts from group modal #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2126 +/- ##
=======================================
Coverage 57.51% 57.51%
=======================================
Files 193 193
Lines 6198 6198
Branches 1718 1718
=======================================
Hits 3565 3565
Misses 2633 2633 ☔ View full report in Codecov by Sentry. |
|
/retest |
mkholjuraev
approved these changes
Jan 2, 2024
| expect(removeHostsFromGroup).toBeCalledWith('g1', ['h1']); | ||
| }); | ||
|
|
||
| it('can remove more groups', async () => { |
There was a problem hiding this comment.
Suggested change
| it('can remove more groups', async () => { | |
| it('can remove multiple groups', async () => { |
A tiny nitpick :)
|
🎉 This PR is included in version 1.62.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some new unit tests for the component.