feat(THEEDGE-3758): show both tabs when adding systems to group #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldjebran
changed the title
ldjebran
changed the title
ldjebran
changed the title
ldjebran
changed the title
ldjebran
force-pushed
the
group-details-add-systems-tabs
branch
from
8e075ba to
9056bf0
Compare
mkholjuraev
reviewed
Dec 13, 2023
There was a problem hiding this comment.
@ldjebran thank you! Codewise looks good and works as described. However, let's add some coverage tests to make sure we avoid any possible future issues before merging.
Show both tabs when adding systems to group, when adding conventional systems, conventional tab should be selected by default and when adding immutable systems, immutable tab should be selected by default. FIXES: https://issues.redhat.com/browse/THEEDGE-3758
ldjebran
force-pushed
the
group-details-add-systems-tabs
branch
from
9056bf0 to
8add871
Compare
|
/retest |
mkholjuraev
approved these changes
Dec 14, 2023
|
/retest |
|
/retest |
|
🎉 This PR is included in version 1.62.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show both tabs when adding systems to group, when adding conventional systems, conventional tab should be selected by default and when adding immutable systems, immutable tab should be selected by default.
FIXES: https://issues.redhat.com/browse/THEEDGE-3758