fix(ESSNTL-5612): Update Staleness & Deletion Keys + Route Protection #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonispuente
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2114 +/- ##
==========================================
- Coverage 57.62% 57.51% -0.11%
==========================================
Files 193 193
Lines 6192 6195 +3
Branches 1713 1715 +2
==========================================
- Hits 3568 3563 -5
- Misses 2624 2632 +8 ☔ View full report in Codecov by Sentry. |
|
/retest |
mkholjuraev
suggested changes
Dec 11, 2023
adonispuente
force-pushed
the
stalenessKeys
branch
from
c48191e to
2cc5e53
Compare
|
@mkholjuraev Sorry about that, The ticket wasnt up to date and I was using an old schema, Ive updated the PR so that its uses the api keys that are now merged into BE stage |
|
/retest |
mkholjuraev
approved these changes
Dec 11, 2023
adonispuente
force-pushed
the
stalenessKeys
branch
from
7c737b9 to
ca2b815
Compare
adonispuente
force-pushed
the
stalenessKeys
branch
from
84cc00e to
9feff57
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
🎉 This PR is included in version 1.61.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no functionality changes frontend wise with this PR. The backend is changing the api keys so the frontend needs to be updated.
This also protects the route via feature flag.
This cannot be merged until RedHatInsights/insights-host-inventory#1573 is merged
New keys with merged PR:
conventional_time_to_stale
"conventional_time_to_stale_warning": "",
"conventional_time_to_delete": "",
"immutable_time_to_stale": "",
"immutable_time_to_stale_warning": "",
"immutable_time_to_delete"