Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inventroyGroup): THEEDGE-3693- implement edge group expostion #2086

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Nov 9, 2023

this commit expose edge group component from edge,
and give the ability if important customer log in to the system and navigate to group screen, he will see edge group list instead of inventory

@mgold1234 mgold1234 requested a review from a team as a code owner November 9, 2023 11:57
@mgold1234 mgold1234 force-pushed the expose_group branch 2 times, most recently from 0d5a144 to 94fec2f Compare November 9, 2023 14:55
@computercamplove
Copy link
Contributor

/retest

@mgold1234 mgold1234 force-pushed the expose_group branch 2 times, most recently from f3168d8 to e09a571 Compare November 12, 2023 09:05
@mgold1234 mgold1234 changed the title implement edge group expostion FIXES (inventroyGroup) THEEDGE-3693: implement edge group expostion Nov 12, 2023
@mgold1234 mgold1234 changed the title FIXES (inventroyGroup) THEEDGE-3693: implement edge group expostion fix (inventroyGroup) -THEEDGE-3693: implement edge group expostion Nov 12, 2023
@mgold1234 mgold1234 force-pushed the expose_group branch 2 times, most recently from 9591394 to aaa2cfd Compare November 13, 2023 08:35
@mgold1234 mgold1234 changed the title fix (inventroyGroup) -THEEDGE-3693: implement edge group expostion fix(inventroyGroup): THEEDGE-3693:- implement edge group expostion Nov 13, 2023
@mgold1234 mgold1234 changed the title fix(inventroyGroup): THEEDGE-3693:- implement edge group expostion fix(inventroyGroup): THEEDGE-3693- implement edge group expostion Nov 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (e3e7158) 58.93% compared to head (851e8d6) 58.50%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/routes/InventoryOrEdgeComponent.js 0.00% 20 Missing ⚠️
src/Utilities/hooks/useEdgeGroups.js 0.00% 16 Missing ⚠️
src/components/InventoryGroups/EdgeGroups.js 0.00% 4 Missing ⚠️
src/api/api.js 25.00% 3 Missing ⚠️
src/Routes.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
- Coverage   58.93%   58.50%   -0.44%     
==========================================
  Files         183      186       +3     
  Lines        5871     5916      +45     
  Branches     1658     1663       +5     
==========================================
+ Hits         3460     3461       +1     
- Misses       2411     2455      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

src/Utilities/hooks/useEdgeGroups.js Outdated Show resolved Hide resolved
src/Utilities/hooks/useEdgeGroups.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one nitpick and good to be merged.

src/Routes.js Outdated Show resolved Hide resolved
Copy link
Contributor

@adonispuente adonispuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgold1234
Copy link
Collaborator Author

/retest

1 similar comment
@mgold1234
Copy link
Collaborator Author

/retest

src/Routes.js Outdated Show resolved Hide resolved
src/Routes.js Outdated Show resolved Hide resolved
src/api/api.js Outdated Show resolved Hide resolved
@gkarat gkarat added the enhancement New feature or request label Nov 16, 2023
@gkarat
Copy link
Contributor

gkarat commented Nov 16, 2023

Can we also use feat instead of fix prefix for the PR title? It looks like a new feature, not a bug fix @mgold1234

@mgold1234 mgold1234 changed the title fix(inventroyGroup): THEEDGE-3693- implement edge group expostion feat(inventroyGroup): THEEDGE-3693- implement edge group expostion Nov 19, 2023
@gkarat gkarat requested review from a team and removed request for ldjebran November 21, 2023 10:33
src/Routes.js Outdated Show resolved Hide resolved
src/routes/InventoryOrEdgeComponent.js Outdated Show resolved Hide resolved
src/routes/InventoryOrEdgeComponent.js Outdated Show resolved Hide resolved
Comment on lines +38 to +39
hasConventionalSystems={hasConventionalSystems}
hasEdgeDevices={hasEdgeDevices}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need these props here? Neither EdgeGroupsView nor InventoryGroups component accepts these two props. I tried to trace EdgeGroupsView federated module interface and found this https://github.com/RedHatInsights/edge-frontend/blob/master/src/Routes/Groups/Groups.js#L21: it only accepts locationProp, navigateProp props.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesnt work without that

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
this fixes story add support for important customer that will navigate
to group screen and show edge group instead of inventory group.
this pr expose Groups component from edge and check if user should see inventory
or edge groups
Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally with both enforced and standard accounts. Thank you @mgold1234!

@gkarat gkarat merged commit 18c7a3e into RedHatInsights:master Nov 21, 2023
2 checks passed
@gkarat
Copy link
Contributor

gkarat commented Nov 21, 2023

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants