fix(ESSNTL-5537): Update RBAC for staleness page + tab conditional #2063
Conversation
adonispuente
changed the title
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
|
/retest |
|
/retest |
There was a problem hiding this comment.
LGTM! tested locally with insights-qa and tried to trace if all of the network requests is sent correctly on the first load and also when updating the staleness values (PATCH, GET, etc.).
Can we also have this PR refer to some of the Jira tickets? Also, make sure the commits that will get into master follow commit conventions (otherwise, the commitlint will be swearing at us).
There are ongoing issues with Travis CI at the moment. But running npm run verify:local on my machine for this PR was successful, so we can assume our tests pass.
| GENERAL_HOST_STALENESS_READ_PERMISSION, | ||
| GENERAL_HOSTS_READ_PERMISSIONS, | ||
| ]; | ||
| const REQUIRED_PERMISSIONS = [GENERAL_HOST_STALENESS_READ_PERMISSION]; |
There was a problem hiding this comment.
I see "inventory:hosts:read (for all hosts)" as one of the required permissions to render the read-only version of the staleness card. Does it mean that we have to update mocks so that it's up to date with these changes?
There was a problem hiding this comment.
On the far right of the mocks youre looking at, are the updated mocks.
There is an additional change in the future regarding these permissions (checking the same thing but deleting certain permissions from RBAC and updating this, but that will be on the last PR for M1 after the backend and RBAC PRs are merged).
adonispuente
changed the title
|
🎉 This PR is included in version 1.54.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…edHatInsights#2063) * fix(ESSNTL-5537): Update RBAC for staleness page + tab conditional RedHatInsights#2062 * fix(ESSNTL-5537): fix test --------- Co-authored-by: Georgii Karataev <[email protected]> feat(THEEDGE-3581): view group detail tabs when group has edge devices
This updates the page to use the new RBAC checks from the mocks : https://miro.com/app/board/uXjVMzdWSVk=/
and also renders the tabs conditionally based on if the user has edge systems or not.
It also updates the tool tip with correct admin permission text