test(RHINENG-3032): Migrate from Enzyme to RTL #2033

gkarat · 2023-09-27T15:07:32Z

Fixes https://issues.redhat.com/browse/RHINENG-3032.

This mirgates all unit tests to the RTL library.

Many tests were moved from asserting against snapshots to specific queries depending on what each test is trying to verify. The reason is that RTL snapshot generation is different to enzyme's and does not support shallow rendering which made many tests unfunctional.
All enzyme and its eco-system packages are removed.
setupTests.js was cleaned and now contains only the most necessary mocks/globals.
All tests were checked with the testing-library/react plugin for eslint.

src/components/GeneralInfo/BiosCard/BiosCard.test.js

src/components/GeneralInfo/InfrastructureCard/InfrastructureCard.test.js

gkarat · 2024-01-20T23:06:23Z

I might introduce minor changes or clean-up again, but I believe the PR is ready for review.

This enables RTL support in the repository so that it is possible to write new unit tests using RTL.

src/components/filters/useGroupFilter.test.js

src/components/InventoryTable/InventoryTable.test.js

src/components/GeneralInfo/dataMapper/dataMapper.test.js

src/components/GeneralInfo/SystemCard/SystemCard.test.js

src/components/GeneralInfo/LoadingCard/LoadingCard.test.js

src/Utilities/TagWithDialog.test.js

gkarat · 2024-02-06T12:16:04Z

Follow-up: #2141

src/components/GeneralInfo/SystemCard/SystemCard.test.js

bastilian

LGTM! At least as far as I can see. Thank you @gkarat!

gkarat · 2024-02-06T13:24:19Z

🎉 This PR is included in version 1.64.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

gkarat added the dependencies Pull requests that update a dependency file label Sep 27, 2023

gkarat self-assigned this Sep 27, 2023

bastilian reviewed Sep 28, 2023

View reviewed changes

src/components/GeneralInfo/BiosCard/BiosCard.test.js Outdated Show resolved Hide resolved

bastilian reviewed Sep 28, 2023

View reviewed changes

src/components/GeneralInfo/InfrastructureCard/InfrastructureCard.test.js Show resolved Hide resolved

gkarat force-pushed the rtl branch from e0051a8 to dd80ac0 Compare October 6, 2023 11:00

mkholjuraev force-pushed the master branch from f7f0f69 to f8aa0a0 Compare October 11, 2023 12:22

gkarat force-pushed the rtl branch 4 times, most recently from 195470b to 70615b1 Compare October 25, 2023 18:55

gkarat force-pushed the rtl branch from 8e51deb to b190740 Compare November 29, 2023 14:48

gkarat force-pushed the rtl branch from 4f0b09e to 787fb69 Compare January 20, 2024 18:41

gkarat marked this pull request as ready for review January 20, 2024 23:00

gkarat requested a review from a team as a code owner January 20, 2024 23:00

gkarat added 15 commits January 22, 2024 11:26

chore: Support RTL and install dependencies

a83c102

This enables RTL support in the repository so that it is possible to write new unit tests using RTL.

chore(Cards): Convert tests to testing-library

0d4f92a

chore: Introduce RouterWrapper

b9f63bc

chore: Enhance TestWrapper and include redux provider

1bd0b2e

chore(EditButton): Convert tests to testing-library

ee06c3d

chore(ConfigurationCard): Convert test to testing-library

0abdc8d

chore(InfrastructureCard): Convert tests to testing-library

17d12ea

chore(BiosCard): Convert tests to testing-library

d915fbb

chore(CollectionCard): Convert tests to testing-library

653be44

chore: Fix default store argument for TestWrapper

8edc4a7

chore(LoadingCard): Convert tests to testing-library

da7db78

chore(EntityTable): Convert tests to testing-library

31caf55

chore(TagWithDialog): Convert tests to testing-library

48bc8c9

chore(OperatingSystemFormatter): Convert tests to testing-library

afe372a

chore(EntityTableToolbar): Convert tests to testing-library

efcb2d9