fix: Use the context version of usePermissions #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usePermissions is unstable and cause bugs in apps that import the InventoryTable module. This makes it stick to the RBAC context and guarantees that RD are not checked.
|
🎉 This PR is included in version 1.35.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #1963.
usePermissions is unstable and cause bugs in apps that import the InventoryTable module. This makes it stick to the RBAC context and guarantees that RD are not checked.
How to test
Try to run this PR together with any other app - Inventory consumer. Make sure Inventory and the apps are not crashing (that used to be the case when there was
usePermissionsversion).