fix(ESSNTL-5239): Improve RBAC check for bulk group actions

[gkarat]

Implements https://issues.redhat.com/browse/ESSNTL-5239.

Must be merged after #1973 and RedHatInsights/frontend-components#1885.

This makes sure that both bulk actions (Remove from group and Add to group) on the /inventory page comply with the RBAC requirements: specifically that the table no longer checks on the global level permissions.

• Write cy tests

How to test

1. Set up inventory:groups:write permission only to specific group
2. Navigate to /inventory
3. Select one or more ungroupped hosts and make sure "Add to group" is enabled; try to add the groups
4. Select some systems in a group that you don't have write permissions: you shouldn't be able to bulk remove them from the group
5. Select some systems in a group that you have write permissions: you should be able to remove them via bulk Remove from group
6. Select the same systems as in 5. + some ungroupped hosts: you still should be able to remove the hosts that are in the group, and the modal should correctly display the number of hosts to be removed.

[LiorKGOW]

Nice work overall @gkarat
I have found a few comments which I am not sure if you intended to keep (marked them with 'here')

Also, I think you could be using the template literal alongside with the ternary operator to shorten the code and remove some code duplication :)
I have added an example of how I thought it could go
In the file: src/components/InventoryGroups/Modals/RemoveHostsFromGroupModal.js

1. line 42
2. line 20

[LiorKGOW]

here

[LiorKGOW]

here

[LiorKGOW]

here

[LiorKGOW]

here

[LiorKGOW]

here

[LiorKGOW]

You could also put all the checks inside the string, using a Template Literal with the ternary operator, and by that remove some code duplication :)

Something like this:

const numOfSystems = hostsInGroup.length;
return {
onSuccess: {
title: `${numOfSystems} system${numOfSystems===1 ? " was" : "s were"} removed from ${groupName}`,
},
onError: {
title: `Failed to remove ${numOfSystems} system${numOfSystems===1 ? "" : "s"} from ${groupName}`,
},
};

[gkarat]

Yeah this is the variant that used to be here. But I decided to rework it for better code readability (even though it's not following DRY 100%).

[LiorKGOW]

These lines can also be shortened using the template literal with the ternary operator 👍🏼
Something like this:

const numOfSystems = hostsInGroup.length;
const systemName = hostsInGroup[0].display_name;

// in the returned JSX (line 19):
label:
  <Text>
    <strong>{numOfSystems === 1 ? systemName : numOfSystems}</strong>{numOfSystems === 1 ? "" : " 
    systems"} will no longer be part of <strong>{groupName}</strong> and {numOfSystems === 1 ? "its" : 
    "their"} configuration will be impacted.
  </Text>

[gkarat]

Thank you. But still, I would like to stick to the current variant (see #1974 (comment) comment)

[gkarat]

🎉 This PR is included in version 1.35.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀