chore(ESSNTL-4076): Upgrade react-router-dom to version 6 #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkholjuraev
force-pushed
the
router-upgrade
branch
2 times, most recently
from
9dbdb6e to
762855a
Compare
gkarat
added
enhancement
labels
gkarat
changed the title
gkarat
requested changes
Aug 11, 2023
| @@ -71,7 +70,7 @@ const EntityTable = ({ | |||
| ); | |||
|
|
|||
| const defaultRowClick = (_event, key) => { | |||
| history.push( | |||
| navigate( | |||
There was a problem hiding this comment.
I think here we can freely use navigate from react-router and just replace with navigate(key) (using relative path).
gkarat
reviewed
Aug 11, 2023
mkholjuraev
force-pushed
the
router-upgrade
branch
from
b708bb7 to
1eebc6d
Compare
|
@gkarat why there is a rage label? |
|
Haha, it just reflects my feelings working on the router upgrade 😄 |
gkarat
approved these changes
Aug 17, 2023
gkarat
force-pushed
the
router-upgrade
branch
2 times, most recently
from
0f8c534 to
a5bc2b1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 62.34% 60.93% -1.41%
==========================================
Files 151 153 +2
Lines 4809 4882 +73
Branches 1360 1361 +1
==========================================
- Hits 2998 2975 -23
- Misses 1811 1907 +96
☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/ESSNTL-4076
Upgrades react-router to v6 and refactors all class components to function components