-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ESSNTL-4194): Minor improvements #1879
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1879 +/- ##
==========================================
- Coverage 65.28% 65.25% -0.03%
==========================================
Files 145 145
Lines 3964 3978 +14
Branches 1125 1129 +4
==========================================
+ Hits 2588 2596 +8
- Misses 1376 1382 +6
☔ View full report in Codecov by Sentry. |
There is now only one test failing which is not related to the PR changes (InventoryGroups). I will research on the cause, but other tests look OK. |
09dea95
to
6e2bbaf
Compare
@RedHatInsights/team-interact can we get 1 approving review? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.22.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements https://issues.redhat.com/browse/ESSNTL-4194.
This PR follows up on #1767 and fixes the following bugs:
How to test