test: Stabilize cypress component tests #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrites some of the tests and makes sure there are no dangling requests in the browser (testing environment) before the next test is executed. Also, it makes all the component tests run in chrome due to the often errors in CI when using electron (by default).
|
@gkarat Tested it locally, tests are passing. LGTM |
Fewwy
approved these changes
Mar 7, 2023
|
🎉 This PR is included in version 1.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
its and thus some tests can assert on wrongly intercepted requests. It must be resolved now bycy.waiting for all requests that we set up interceptors for./groups. If in the tests we change the pagination and thency.waitfor the new paginated request, then it can happen that the first requests hasn't been finished yet andcy.waitwill catch the very first request instead of the request made after changing pagination (the one we need to check).Could not process 'reset:browser:tabs:for:next:test'. No automation clients connected.error. Cypress 10 component test crash after 100~ tests cypress-io/cypress#22208 suggests to force running in chrome.How to test
CI must pass.