Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ESSNTL-4365): Enable actions in the groups table #1779

Merged
merged 4 commits into from
Mar 3, 2023
Merged

feat(ESSNTL-4365): Enable actions in the groups table #1779

merged 4 commits into from
Mar 3, 2023

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Mar 1, 2023 •
edited
Loading

Implements https://issues.redhat.com/browse/ESSNTL-4365.

  • Connects modals to the appropriate action buttons in the groups table.
  • Improves the delete group modal so that it can accept more group IDs and perform the deletion request with multiple IDs.

How to test:

  1. Run npm run mock-server and npm run start:mock:beta in separate terminals.
  2. Navigate to https://stage.foo.redhat.com:1337/beta/insights/inventory/groups.
  3. Use toolbar or per-row actions kebab to use the features on selected groups.
  4. Check the right network requests are made after performing any action. (visually there can be some bugs due to the mocked crazy API).
  5. Check the components tests pass.

Screenshots

image

image

image

gkarat added 2 commits March 1, 2023 15:08
@gkarat
Connect modals to the groups table actions
3d79b85 
Implements https://issues.redhat.com/browse/ESSNTL-4365.

This enables the creation, deletion and renaming of one group in the
groups table.
@gkarat
Fix propTypes for groups modals
d08cd6e
@gkarat gkarat added the enhancement New feature or request label Mar 1, 2023
@gkarat gkarat requested a review from Fewwy March 1, 2023 14:14
@gkarat gkarat requested a review from a team as a code owner March 1, 2023 14:14
@gkarat gkarat self-assigned this Mar 1, 2023
@gkarat
Copy link
Contributor Author

gkarat commented Mar 1, 2023

/retest

@gkarat
Copy link
Contributor Author

gkarat commented Mar 2, 2023

Putting to draft state, gonna add one more commit to enable multiple groups deletion...

@gkarat gkarat marked this pull request as draft March 2, 2023 11:50
@gkarat gkarat marked this pull request as ready for review March 2, 2023 12:17
Fewwy
Fewwy approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally. LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 40.50% and project coverage change: -2.84 ⚠️

Comparison is base (ca24e55) 70.45% compared to head (4061ad2) 67.62%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1779      +/-   ##
==========================================
- Coverage   70.45%   67.62%   -2.84%     
==========================================
  Files         122      124       +2     
  Lines        2579     2758     +179     
  Branches      885      912      +27     
==========================================
+ Hits         1817     1865      +48     
- Misses        762      893     +131
Impacted Files Coverage Δ
src/components/GroupsTable/GroupsTable.cy.js 0.00% <0.00%> (ø)
...ponents/InventoryGroups/Modals/CreateGroupModal.js 72.22% <ø> (+11.11%) ⬆️
...ents/InventoryGroups/Modals/DeleteGroupModal.cy.js 0.00% <0.00%> (ø)
...ponents/InventoryGroups/Modals/RenameGroupModal.js 100.00% <ø> (ø)
src/components/SystemDetails/Advisor.js 0.00% <0.00%> (ø)
src/components/GroupsTable/GroupsTable.js 88.79% <83.05%> (-5.95%) ⬇️
src/Utilities/hooks/useFetchBatched.js 100.00% <100.00%> (ø)
src/Utilities/hooks/usePromiseQueue.js 100.00% <100.00%> (ø)
...ponents/InventoryGroups/Modals/DeleteGroupModal.js 100.00% <100.00%> (ø)
src/components/InventoryGroups/utils/api.js 93.75% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkarat gkarat merged commit aa8ed51 into RedHatInsights:master Mar 3, 2023
@gkarat gkarat deleted the essntl-4365-actions-groups-table branch March 3, 2023 11:43
gkarat pushed a commit that referenced this pull request Mar 3, 2023
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
1ea0d2c 
# [1.6.0](v1.5.0...v1.6.0) (2023-03-03)

### Features

* **ESSNTL-4365:** Enable actions in the groups table ([#1779](#1779)) ([aa8ed51](aa8ed51))
@gkarat
Copy link
Contributor Author

gkarat commented Mar 3, 2023

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fewwy Fewwy Fewwy approved these changes

Assignees

@gkarat gkarat

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkarat @codecov-commenter @Fewwy