feat(ESSNTL-4365): Select rows in the groups table #1775
Conversation
Implements https://issues.redhat.com/browse/ESSNTL-4365. This enables selection of rows in the Inventory groups table.
| @@ -208,6 +246,47 @@ const GroupsTable = () => { | |||
| }} | |||
| filterConfig={{ items: filterConfigItems }} | |||
| activeFiltersConfig={activeFiltersConfig} | |||
| bulkSelect={{ | |||
| items: [ | |||
There was a problem hiding this comment.
A minor: I think if we move this bulk select config object outside of the JSX rendering section, we would have even cleaner code. We can also separate this into a callback as the function definition does not change often.
|
select none works correctly |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1775 +/- ##
==========================================
- Coverage 70.45% 68.69% -1.76%
==========================================
Files 122 124 +2
Lines 2579 2677 +98
Branches 885 900 +15
==========================================
+ Hits 1817 1839 +22
- Misses 762 838 +76
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# [1.5.0](v1.4.0...v1.5.0) (2023-03-01) ### Bug Fixes * **ESSNTL-4387:** Pass down inventoryId to Advisor ([#1773](#1773)) ([72e017e](72e017e)) ### Features * **ESSNTL-4365:** Select rows in the groups table ([#1775](#1775)) ([2d81ac7](2d81ac7))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements https://issues.redhat.com/browse/ESSNTL-4365 (1/2, the actions will be implemented in a separate PR).
This makes possible to select rows in the groups table separately or in bulk. Component tests are implemented to verify the correct request URLs. The selection drop down shows three options according to the UX tables audit document (Stefan Kukla).
How to test
npm run start:mockandnpm run mock-serverin separate terminals.npm run test:openctand find the new tests. You can play with the table there too.Screenshots