Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update inventory detail docs, handle system not found more nicely #1774

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

mkholjuraev
Copy link
Contributor

Updates inventory detail docs, and hides the main section if the system does not exist.

To test the main section related change:

  1. Open one of the oldest systems (we need to choose a system that is not needed)
  2. Click on the Delete button on the top right side.
  3. Refresh the page. You should see the old nicely designed system not found component.

@mkholjuraev mkholjuraev requested a review from a team as a code owner February 23, 2023 08:47
Copy link
Contributor

@adonispuente adonispuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works as intended. Observed no issues when testing against other apps as well

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.98 ⚠️

Comparison is base (6b42a24) 68.60% compared to head (8fb6cee) 67.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
- Coverage   68.60%   67.63%   -0.98%     
==========================================
  Files         124      124              
  Lines        2762     2762              
  Branches      915      915              
==========================================
- Hits         1895     1868      -27     
- Misses        867      894      +27     
Impacted Files Coverage Δ
src/components/InventoryDetail/InventoryDetail.js 0.00% <0.00%> (ø)
src/routes/InventoryDetail.js 0.00% <ø> (ø)
src/api/api.js 45.78% <0.00%> (-18.08%) ⬇️
src/routes/InventoryTable.js 60.34% <0.00%> (-7.76%) ⬇️
src/components/InventoryTable/InventoryTable.js 94.73% <0.00%> (-5.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkholjuraev mkholjuraev merged commit 1718f97 into RedHatInsights:master Mar 6, 2023
@gkarat
Copy link
Contributor

gkarat commented Mar 7, 2023

🎉 This PR is included in version 1.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants