Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(RHIF-167): get rid of activeApps in redux #1754

Merged
merged 6 commits into from
Feb 22, 2023
Merged

perf(RHIF-167): get rid of activeApps in redux #1754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1e5046
perf(RHIF-167): get rid of activeApps in redux
mkholjuraev Feb 1, 2023
c556d0d
chore: decouple the inventory header and main section
mkholjuraev Feb 10, 2023
6637e28
imrove with review suggestions
mkholjuraev Feb 14, 2023
ce72958
fix useEffect deps to loadEntity
mkholjuraev Feb 16, 2023
324e9d0
Merge branch 'master' into refactor-detail
karelhala Feb 20, 2023
2d8be06
Merge branch 'master' into refactor-detail
mkholjuraev Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/dev.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ plugins.push(
'./InventoryTable': resolve(__dirname, '../src/modules/InventoryTable.js'),
'./AppInfo': resolve(__dirname, '../src/modules/AppInfo.js'),
'./InventoryDetailHead': resolve(__dirname, '../src/modules/InventoryDetailHead.js'),
'./DetailHeader': resolve(__dirname, '../src/modules/DetailHeader.js'),
'./InventoryDetail': resolve(__dirname, '../src/modules/InventoryDetail.js'),
'./TagWithDialog': resolve(__dirname, '../src/modules/TagWithDialog.js'),
'./DetailWrapper': resolve(__dirname, '../src/modules/DetailWrapper.js'),
Expand Down
1 change: 1 addition & 0 deletions config/prod.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ plugins.push(
'./InventoryTable': resolve(__dirname, '../src/modules/InventoryTable.js'),
'./AppInfo': resolve(__dirname, '../src/modules/AppInfo.js'),
'./InventoryDetailHead': resolve(__dirname, '../src/modules/InventoryDetailHead.js'),
'./DetailHeader': resolve(__dirname, '../src/modules/DetailHeader.js'),
'./InventoryDetail': resolve(__dirname, '../src/modules/InventoryDetail.js'),
'./TagWithDialog': resolve(__dirname, '../src/modules/TagWithDialog.js'),
'./DetailWrapper': resolve(__dirname, '../src/modules/DetailWrapper.js'),
Expand Down
1 change: 0 additions & 1 deletion doc/inventory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,6 @@ These actions are fired from inventory component. If action is marked with `*` i
* `SELECT_ENTITY` - if user clicks on checkbox in entity list
* `CHANGE_SORT` - when user changes sort
* `FILTER_ENTITIES` - when user wants to filter entities
* `APPLICATION_SELECTED` - fired after user clicks on application detail

## Store shape
As mentioned before the async loader will load two functions `mergeWithEntities` and `mergeWithDetail` both have access to your store and they will create specific keys in store. Please do not change the data directly, since that can break the inventory component.
Expand Down
2 changes: 1 addition & 1 deletion src/api/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export async function getEntities(items, {
fields = { system_profile: ['operating_system'] },
...options
}, showTags) {
if (hasItems && items.length > 0) {
if (hasItems && items?.length > 0) {
let data = await hosts.apiHostGetHostById(
items,
undefined,
Expand Down
Loading