Fixes for operating_system's display issues #1451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues:
I was going to make separate PRs for these, but they ended up being too tightly coupled. I refactored a bit so that we could reuse
OperatingSystemFormatter
; this added a<span>
around the Release value, so I had to update the snapshots as well. There isn't isn't a visible change in the formatting, though the Release field now includes the name, e.g. "RHEL 8.0" instead of "8.0". Is that an issue?