Resource tab optimization

src/components/InventoryDetail/ApplicationDetails.js

@@ -1,4 +1,4 @@
-import React, { useEffect } from 'react';
+import React, { useEffect, useState } from 'react';
 import PropTypes from 'prop-types';
 import { useSelector, useDispatch } from 'react-redux';
 import { useLocation, useHistory } from 'react-router-dom';
@@ -14,11 +14,14 @@ const ApplicationDetails = ({ onTabSelect, appList, ...props }) => {
     const history = useHistory();
     const dispatch = useDispatch();
     const searchParams = new URLSearchParams(search);
-    const items = useSelector(({ entityDetails }) => entityDetails?.activeApps);
+    const items = useSelector(({ entityDetails }) => entityDetails?.activeApps.filter(({ isVisible }) => isVisible !== false));
     const activeApp = useSelector(({ entityDetails }) => entityDetails?.activeApp);
+    const disabledApps = useSelector(({ systemProfileStore }) => systemProfileStore?.disabledApps);
     const defaultApp = activeApp?.appName || appList?.find(({ pageId, name }) => items?.[0]?.name === (
         pageId || name))?.name || items?.[0]?.name;
-    const applications = appList || items;
+    let applications = appList || items;
+    const [activeTabs, setActiveTabs] = useState(applications);
+
     useEffect(() => {
         /**
          * Initialize first inventory detail type
@@ -29,6 +32,16 @@ const ApplicationDetails = ({ onTabSelect, appList, ...props }) => {
         }
     }, []);
 
+    useEffect(() => {
+        const filteredResult = disabledApps && disabledApps.length && applications.filter(app => app.name !== disabledApps[0]);
+        if (filteredResult !== 0 && typeof filteredResult !== undefined) {
+            setActiveTabs(filteredResult);
+        }
+        else {
+            setActiveTabs(applications);
+        }
+    }, [disabledApps]);
+
     return (
         <React.Fragment>
             {
@@ -37,7 +50,7 @@ const ApplicationDetails = ({ onTabSelect, appList, ...props }) => {
                     {...props}
                     activeKey={ defaultApp }
                     onSelect={ (event, item) => {
-                        const activeItem = applications.find(oneApp => oneApp.name === item);
+                        const activeItem = activeTabs.find(oneApp => oneApp.name === item);
                         if (onTabSelect) {
                             onTabSelect(event, item, activeItem);
                         } else {
@@ -50,7 +63,7 @@ const ApplicationDetails = ({ onTabSelect, appList, ...props }) => {
                     isFilled
                     className="ins-c-inventory-detail__app-tabs"
                 >
-                    { applications.map((item, key) => (
+                    { activeTabs && activeTabs.length && activeTabs.map((item, key) => (
                         <Tab key={ key } eventKey={ item.name } title={ item.title }></Tab>
                     )) }
                 </Tabs>

src/components/InventoryTable/InventoryTable.js

@@ -129,8 +129,6 @@ const InventoryTable = forwardRef(({ // eslint-disable-line react/display-name
     const onRefreshData = (options = {}, disableOnRefresh) => {
         const { activeFilters } = store.getState().entities;
         const cachedProps = cache.current?.getProps() || {};
-
-        // eslint-disable-next-line camelcase
         const currPerPage = options?.per_page || options?.perPage || cachedProps.perPage;
 
         const params = {

src/store/action-types.js

@@ -65,3 +65,4 @@ export const CLEAR_FILTERS = 'CLEAR_FILTERS';
 export const TOGGLE_TAG_MODAL = 'TOGGLE_TAG_MODAL';
 export const CONFIG_CHANGED = 'CONFIG_CHANGED';
 export const TOGGLE_DRAWER = 'TOGGLE_INVENTORY_DRAWER';
+export const SET_ROS_TAB_VISBILITY = 'SET_ROS_TAB_VISBILITY';

src/store/inventory-actions.js

@@ -193,6 +193,11 @@ export const deleteEntity = (systems, displayName) => ({
     }
 });
 
+// export const setRosTabVisibility = (shouldShowRosTab) => ({
+//     type: SET_ROS_TAB_VISBILITY,
+//     payload: shouldShowRosTab
+// });
+
 export const configChanged = (config) => ({
     type: CONFIG_CHANGED,
     payload: config

src/store/reducers.js

@@ -1,4 +1,10 @@
-import { INVENTORY_ACTION_TYPES, ACTION_TYPES, SELECT_ENTITY, SET_INVENTORY_FILTER, SET_PAGINATION } from './action-types';
+import {
+    INVENTORY_ACTION_TYPES,
+    ACTION_TYPES,
+    SELECT_ENTITY,
+    SET_INVENTORY_FILTER,
+    SET_PAGINATION
+} from './action-types';
 import systemProfileStore from './systemProfileStore';
 import {
     ComplianceTab,
@@ -64,6 +70,7 @@ function entityLoaded(state) {
             (!insights.chrome.isProd || (insights.chrome.isProd && insights?.chrome?.isBeta())) && {
                 title: 'Resource Optimization',
                 name: 'ros',
+                isVisible: false,
                 component: RosTab
             }
         ].filter(Boolean)
@@ -95,6 +102,17 @@ function entitySelected(state, { payload }) {
     };
 }
 
+function resourceOptTabVisibility(state, { payload }) {
+    return {
+        ...state,
+        activeApps: state.activeApps?.map((entity) => entity.name === 'ros' ? ({
+            ...entity,
+            isVisible: payload
+        }) : entity
+        )
+    };
+}
+
 function entityDeleted(state, { meta }) {
     const selected = state.selected || (new Map());
     meta.systems.forEach(id => selected.delete(id));
@@ -105,11 +123,7 @@ function entityDeleted(state, { meta }) {
     };
 }
 
-function onEntitiesLoaded(state, { payload, meta }) {
-    if (meta?.lastDateRequest < state?.lastDateRequest) {
-        return state;
-    }
-
+function onEntitiesLoaded(state, { payload }) {
     return {
         ...state,
         rows: mergeArraysByKey([state.rows, payload.results.map(result => {
@@ -160,7 +174,8 @@ export const tableReducer = applyReducerHash(
 
 export const entitesDetailReducer = () => applyReducerHash(
     {
-        [INVENTORY_ACTION_TYPES.LOAD_ENTITY_FULFILLED]: entityLoaded
+        [INVENTORY_ACTION_TYPES.LOAD_ENTITY_FULFILLED]: entityLoaded,
+        [INVENTORY_ACTION_TYPES.LOAD_SYSTEM_PROFILE_FULFILLED]: resourceOptTabVisibility
     },
     defaultState
 );

src/store/systemProfileStore.js

@@ -45,8 +45,14 @@ export function calculateInterfaces(interfaces) {
 
 export function onSystemProfile(state, { payload: { results } }) {
     const systemProfile = (results && results[0] && results[0].system_profile) || {};
+    const cloudProviderObj = (results && results[0] && (typeof results[0].system_profile.cloud_provider !== 'undefined'))
+                        && results[0].system_profile.cloud_provider;
     return {
         ...state,
+        disabledApps: [
+            ...(cloudProviderObj === 'aws' || cloudProviderObj === 'test cloud provider') ? [] : ['ros']
+            // ...(cloudProviderObj === 'aws' || cloudProviderObj === 'azure') ? ['ros'] : []
+        ],
         systemProfile: {
             loaded: true,
             ...systemProfile,