Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-5932): Fix found visual regressions after PF5 migration #2148

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Feb 21, 2024

Fixes some of the bugs described in https://issues.redhat.com/browse/RHINENG-5932 comments.

This:

  • On the staleness page, aligns the card title and popover
  • Fixes all the icons that missed colours (danger, warning)
  • On the groups page, aligns horizontally the Create group button with the rest of the toolbar
  • Adds missing OUIA IDs and extends the OUIA coverage for the bulk select, conditional filter and actions in PrimaryToolbar.

@gkarat gkarat added the bug Something isn't working label Feb 21, 2024
@gkarat gkarat self-assigned this Feb 21, 2024
@gkarat gkarat requested a review from a team as a code owner February 21, 2024 12:40
@gkarat gkarat marked this pull request as draft February 21, 2024 15:10
@gkarat
Copy link
Contributor Author

gkarat commented Feb 21, 2024

I'd also bump FEC config and update OUIA IDs for conditional filters. Let's wait for RedHatInsights/frontend-components#1972 to be merged first.

@gkarat gkarat marked this pull request as ready for review February 22, 2024 13:40
@gkarat gkarat requested a review from a team February 27, 2024 12:15
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.91%. Comparing base (fd3e39e) to head (28cdebe).

Files Patch % Lines
...ponents/InventoryGroups/Modals/DeleteGroupModal.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2148   +/-   ##
=======================================
  Coverage   42.91%   42.91%           
=======================================
  Files         196      196           
  Lines        6273     6273           
  Branches     1751     1751           
=======================================
  Hits         2692     2692           
  Misses       3581     3581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @gkarat 😄

@gkarat gkarat merged commit 2465ce8 into RedHatInsights:master Feb 28, 2024
1 check passed
@gkarat gkarat deleted the rhineng-5932-follow-up branch February 28, 2024 11:09
@gkarat
Copy link
Contributor Author

gkarat commented Feb 28, 2024

🎉 This PR is included in version 1.64.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants