Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enhance OUIA IDs for ConditionalFilter #1972

Merged
merged 6 commits into from
Feb 22, 2024
Merged

chore: Enhance OUIA IDs for ConditionalFilter #1972

merged 6 commits into from
Feb 22, 2024

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Feb 21, 2024

This improves the naming for the OUIA IDs for ConditionalFilter and covers more elements.

@gkarat gkarat added the components update to components package label Feb 21, 2024
@gkarat gkarat self-assigned this Feb 21, 2024
@gkarat gkarat marked this pull request as draft February 21, 2024 15:10
@gkarat
Copy link
Contributor Author

gkarat commented Feb 21, 2024

I will wait for QE approval that these IDs are acceptable and then will open the PR for review.

@gkarat gkarat mentioned this pull request Feb 21, 2024
Merged
@gkarat gkarat marked this pull request as ready for review February 22, 2024 09:15
@gkarat gkarat requested review from Hyperkid123, fhlavac, karelhala and a team February 22, 2024 09:16
@gkarat gkarat marked this pull request as draft February 22, 2024 09:40
Fewwy
Fewwy approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkarat gkarat marked this pull request as ready for review February 22, 2024 12:05
Fewwy
Fewwy approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more LGTM

@gkarat gkarat merged commit 56b406c into RedHatInsights:master Feb 22, 2024
1 check passed
@gkarat gkarat deleted the rhineng-5932 branch February 22, 2024 13:02
@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Feb 22, 2024
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/frontend-components/v/4.2.4📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Feb 22, 2024
@Fewwy Fewwy mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fewwy Fewwy Fewwy approved these changes

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123

@fhlavac fhlavac Awaiting requested review from fhlavac

@karelhala karelhala Awaiting requested review from karelhala

Assignees

@gkarat gkarat

Labels
components update to components package release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkarat @nacho-bot @Fewwy @Hyperkid123