-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(THEEDGE-3764): fixes LoadingCard component #2123
fix(THEEDGE-3764): fixes LoadingCard component #2123
Conversation
c11ac78
to
29886ed
Compare
A regression happened from latest changes when used in federated mode, preventing the model dialogs to open, as no way in federated mode to find the modelId. This PR revert the change related of using useParams function "Clickable" and add the full pathname to the url, also needed as in federated mode the path was truncated for example when used in edge-management app the path was "/edge/ipv4", with this change the path is correct and looks like "/edge/inventory/9ea55e32-6e30-4288-bf08-0a877c7fd306/ipv4" FIXES: https://issues.redhat.com/browse/THEEDGE-3764
29886ed
to
5f400f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2123 +/- ##
==========================================
- Coverage 57.51% 57.45% -0.06%
==========================================
Files 193 193
Lines 6195 6196 +1
Branches 1715 1715
==========================================
- Hits 3563 3560 -3
- Misses 2632 2636 +4 ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ldjebran for the PR. I tested it locally and it works fine.
However, I think the reason why edge is having such issues is due to the fact that it hasn't yet migrated to react-router v6, uses its own Router and doesn't set react-router as singleton in it webpack config. This way, by sharing the same router instance across apps, the federated module will also respect the pathname and recognise route params. I recommend to look into this and reserve some time in the soonest future to avoid such bugs and workarounds.
🎉 This PR is included in version 1.61.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
A regression happened from latest changes (#1968) when used in federated mode, preventing the model dialogs to open, as no way in federated mode to find the modelId.
This PR revert the change related of using useParams in function "Clickable" and add the full pathname to the url, also needed as in federated mode the path was truncated for example when used in edge-management app the path was "/edge/ipv4", with this change the path is correct and looks like "/edge/inventory/9ea55e32-6e30-4288-bf08-0a877c7fd306/ipv4"
FIXES: https://issues.redhat.com/browse/THEEDGE-3764