fix(ESSNTL-5210): Check RBAC for null group id when hosts are not in any group #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
- Coverage 63.45% 62.09% -1.37%
==========================================
Files 151 151
Lines 4726 4741 +15
Branches 1369 1366 -3
==========================================
- Hits 2999 2944 -55
- Misses 1727 1797 +70
☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.36.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://issues.redhat.com/browse/ESSNTL-5210.
Must be merged after RedHatInsights/frontend-components#1886 is released.
At /inventory, users must have Delete (both bulk and per-row) and Edit actions enabled for hosts that are not in any group if the users have write permissions with group.id set to
null.How to test
group.idto null (see more details in the attached Jira)2.Navigate to /inventory and make sure you see the ungroupped hosts and able to edit or delete them.