Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix usage of null values in RBAC RDs #1886

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Aug 13, 2023

Make sure null values are not left out when RBAC RD value is an array.

@gkarat
Copy link
Contributor Author

gkarat commented Aug 14, 2023

Ooopsie, let me remove these console.logs first 😄

@gkarat gkarat force-pushed the rbac-utils-null-value branch 2 times, most recently from cf06665 to 3b33e20 Compare August 14, 2023 08:17
Make sure null values are not left out when RBAC RD value is an array.
@gkarat gkarat force-pushed the rbac-utils-null-value branch from 3b33e20 to 9583dd1 Compare August 14, 2023 08:17
@gkarat
Copy link
Contributor Author

gkarat commented Aug 14, 2023

Done ✔️

Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @gkarat!

@gkarat gkarat merged commit aad86f6 into RedHatInsights:master Aug 14, 2023
@gkarat gkarat deleted the rbac-utils-null-value branch August 14, 2023 09:08
@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Aug 14, 2023
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-utilities/v/3.7.6📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Once merged it will trigger bugfix release released Pr has been released utils update to utils package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants