perf(RHIF-167): get rid of activeApps in redux

RedHatInsights · Feb 9, 2023 · e1e5046 · e1e5046
1 parent c157527
commit e1e5046
Show file tree

Hide file tree

Showing 28 changed files with 22,185 additions and 19,996 deletions.
diff --git a/config/dev.webpack.config.js b/config/dev.webpack.config.js
@@ -78,6 +78,7 @@ plugins.push(
             './InventoryTable': resolve(__dirname, '../src/modules/InventoryTable.js'),
             './AppInfo': resolve(__dirname, '../src/modules/AppInfo.js'),
             './InventoryDetailHead': resolve(__dirname, '../src/modules/InventoryDetailHead.js'),
+            './DetailHeader': resolve(__dirname, '../src/modules/DetailHeader.js'),
             './InventoryDetail': resolve(__dirname, '../src/modules/InventoryDetail.js'),
             './TagWithDialog': resolve(__dirname, '../src/modules/TagWithDialog.js'),
             './DetailWrapper': resolve(__dirname, '../src/modules/DetailWrapper.js'),

diff --git a/config/prod.webpack.config.js b/config/prod.webpack.config.js
@@ -34,6 +34,7 @@ plugins.push(
             './InventoryTable': resolve(__dirname, '../src/modules/InventoryTable.js'),
             './AppInfo': resolve(__dirname, '../src/modules/AppInfo.js'),
             './InventoryDetailHead': resolve(__dirname, '../src/modules/InventoryDetailHead.js'),
+            './DetailHeader': resolve(__dirname, '../src/modules/DetailHeader.js'),
             './InventoryDetail': resolve(__dirname, '../src/modules/InventoryDetail.js'),
             './TagWithDialog': resolve(__dirname, '../src/modules/TagWithDialog.js'),
             './DetailWrapper': resolve(__dirname, '../src/modules/DetailWrapper.js'),

diff --git a/doc/inventory.md b/doc/inventory.md
@@ -747,7 +747,6 @@ These actions are fired from inventory component. If action is marked with `*` i
 * `SELECT_ENTITY` - if user clicks on checkbox in entity list
 * `CHANGE_SORT` - when user changes sort
 * `FILTER_ENTITIES` - when user wants to filter entities
-* `APPLICATION_SELECTED` - fired after user clicks on application detail
 
 ## Store shape
 As mentioned before the async loader will load two functions `mergeWithEntities` and `mergeWithDetail` both have access to your store and they will create specific keys in store. Please do not change the data directly, since that can break the inventory component.

diff --git a/src/api/api.js b/src/api/api.js
@@ -112,7 +112,7 @@ export async function getEntities(items, {
     fields = { system_profile: ['operating_system'] },
     ...options
 }, showTags) {
-    if (hasItems && items.length > 0) {
+    if (hasItems && items?.length > 0) {
         let data = await hosts.apiHostGetHostById(
             items,
             undefined,