test: Remove unnecessary window chrome mock

RedHatInsights · Nov 15, 2023 · 7a3136c · 7a3136c
1 parent 1ce3907
commit 7a3136c
Show file tree

Hide file tree

Showing 16 changed files with 35 additions and 39 deletions.
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
@@ -63,12 +63,8 @@ Cypress.Commands.add('mountWithContext', (Component, options = {}, props) => {
 
 // one of the fec dependencies talks to window.insights.chrome
 Cypress.Commands.add(
-  'mockWindowChrome',
+  'mockWindowInsights',
   ({ userPermissions } = { userPermissions: ['*:*:*'] }) => {
-    window.chrome = {
-      ...window.chrome,
-      getApp: () => 'inventory',
-    };
     window.insights = {
       ...window.insights,
       chrome: {

diff --git a/src/components/GroupSystems/GroupSystems.cy.js b/src/components/GroupSystems/GroupSystems.cy.js
@@ -86,7 +86,7 @@ describe('test data', () => {
 });
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 describe('renders correctly', () => {
@@ -457,7 +457,7 @@ describe('integration with rbac', () => {
 
   describe('has only read permissions', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: READ_PERMISSIONS_WITH_RD,
       });
     });
@@ -481,7 +481,7 @@ describe('integration with rbac', () => {
 
   describe('has groups write permissions', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           ...READ_PERMISSIONS_WITH_RD,
           ...WRITE_PERMISSIONS_WITH_RD,

diff --git a/src/components/GroupsTable/GroupsTable.cy.js b/src/components/GroupsTable/GroupsTable.cy.js
@@ -41,7 +41,7 @@ const mountTable = (initialEntry = '/') =>
   });
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 const waitTable = () =>
@@ -427,7 +427,7 @@ describe('edge cases', () => {
 describe('integration with rbac', () => {
   describe('with only groups read', () => {
     before(() => {
-      cy.mockWindowChrome({ userPermissions: ['inventory:groups:read'] });
+      cy.mockWindowInsights({ userPermissions: ['inventory:groups:read'] });
     });
 
     beforeEach(() => {
@@ -455,7 +455,7 @@ describe('integration with rbac', () => {
 
   describe('with the write permissions for some groups', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           'inventory:groups:read',
           {

diff --git a/src/components/ImmutableDevices/ImmutableDevices.cy.js b/src/components/ImmutableDevices/ImmutableDevices.cy.js
@@ -43,7 +43,7 @@ const mountWithProps = (props) => {
 };
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 describe('ImmutableDevices', () => {

diff --git a/src/components/InventoryGroupDetail/GroupDetailInfo.cy.js b/src/components/InventoryGroupDetail/GroupDetailInfo.cy.js
@@ -5,7 +5,7 @@ const mountPage = (params) =>
 
 describe('group detail information page', () => {
   before(() => {
-    cy.mockWindowChrome({ userPermissions: ['rbac:*:*'] });
+    cy.mockWindowInsights({ userPermissions: ['rbac:*:*'] });
   });
 
   beforeEach(() => {
@@ -42,7 +42,7 @@ describe('group detail information page', () => {
 
   describe('with no user access administrator role', () => {
     beforeEach(() => {
-      cy.mockWindowChrome({ userPermissions: [] });
+      cy.mockWindowInsights({ userPermissions: [] });
       mountPage({ chrome: { isBeta: () => true } });
     });
 

diff --git a/src/components/InventoryGroupDetail/InventoryGroupDetail.cy.js b/src/components/InventoryGroupDetail/InventoryGroupDetail.cy.js
@@ -21,7 +21,7 @@ const mountPage = () =>
   });
 
 before(() => {
-  cy.mockWindowChrome(); // with all permissions
+  cy.mockWindowInsights(); // with all permissions
 });
 
 const waitPageLoad = () =>
@@ -95,7 +95,7 @@ describe('group detail page', () => {
 describe('integration with rbac', () => {
   describe('no permissions', () => {
     before(() => {
-      cy.mockWindowChrome({ userPermissions: [] });
+      cy.mockWindowInsights({ userPermissions: [] });
     });
 
     beforeEach(() => {
@@ -133,7 +133,7 @@ describe('integration with rbac', () => {
 
   describe('only groups read permissions', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           {
             permission: 'inventory:groups:read',
@@ -182,7 +182,7 @@ describe('integration with rbac', () => {
 
   describe('only group read and hosts read permission', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           'inventory:hosts:read',
           {

diff --git a/src/components/InventoryGroups/InventoryGroups.cy.js b/src/components/InventoryGroups/InventoryGroups.cy.js
@@ -4,7 +4,7 @@ import InventoryGroups from './InventoryGroups';
 const mountPage = () => cy.mountWithContext(InventoryGroups);
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 describe('groups table page', () => {
@@ -44,7 +44,7 @@ describe('groups table page', () => {
   describe('integration with rbac', () => {
     it('disables empty state button when not enough permissions', () => {
       interceptors['successful empty']();
-      cy.mockWindowChrome({ userPermissions: [] });
+      cy.mockWindowInsights({ userPermissions: [] });
       mountPage();
 
       cy.ouiaId('CreateGroupButton').shouldHaveAriaDisabled();

diff --git a/src/components/InventoryGroups/Modals/AddSelectedHostsToGroupModal.cy.js b/src/components/InventoryGroups/Modals/AddSelectedHostsToGroupModal.cy.js
@@ -24,7 +24,7 @@ const mountModal = (
 describe('AddSelectedHostsToGroupModal', () => {
   describe('without any permissions', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [],
       });
     });
@@ -42,7 +42,7 @@ describe('AddSelectedHostsToGroupModal', () => {
 
   describe('with limited groups write permissions', () => {
     it('should still hide the create group button', () => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           {
             resourceDefinitions: [
@@ -66,7 +66,7 @@ describe('AddSelectedHostsToGroupModal', () => {
 
   describe('with groups write permission', () => {
     before(() => {
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: ['inventory:groups:write'],
       });
     });

diff --git a/src/components/InventoryGroups/Modals/AddSystemsToGroupModal.cy.js b/src/components/InventoryGroups/Modals/AddSystemsToGroupModal.cy.js
@@ -41,7 +41,7 @@ const AVAILABLE_FILTER_NAMES = [
 const ALERT = '[data-ouia-component-type="PF4/Alert"]';
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 const mountModal = () =>

diff --git a/src/components/InventoryGroups/Modals/CreateGroupModal.cy.js b/src/components/InventoryGroups/Modals/CreateGroupModal.cy.js
@@ -49,7 +49,7 @@ const mockResponse = [
 
 describe('Create Group Modal', () => {
   before(() => {
-    cy.mockWindowChrome();
+    cy.mockWindowInsights();
   });
 
   beforeEach(() => {

diff --git a/src/components/InventoryGroups/Modals/DeleteGroupModal.cy.js b/src/components/InventoryGroups/Modals/DeleteGroupModal.cy.js
@@ -40,7 +40,7 @@ fixtures.results = [
 
 describe('Delete Group Modal', () => {
   before(() => {
-    cy.mockWindowChrome();
+    cy.mockWindowInsights();
   });
 
   describe('multiple hosts', () => {

diff --git a/src/components/InventoryGroups/Modals/RenameGroupModal.cy.js b/src/components/InventoryGroups/Modals/RenameGroupModal.cy.js
@@ -26,7 +26,7 @@ describe('test data', () => {
 
 describe('render the modal', () => {
   before(() => {
-    cy.mockWindowChrome();
+    cy.mockWindowInsights();
   });
 
   beforeEach(setInterceptors);

diff --git a/src/components/InventoryTable/InventoryTable.cy.js b/src/components/InventoryTable/InventoryTable.cy.js
@@ -79,7 +79,7 @@ const setTableInterceptors = () => {
 
 describe('with default parameters', () => {
   before(() => {
-    cy.mockWindowChrome();
+    cy.mockWindowInsights();
   });
 
   beforeEach(() => {
@@ -246,7 +246,7 @@ describe('with default parameters', () => {
 });
 
 describe('hiding filters', () => {
-  before(cy.mockWindowChrome);
+  before(cy.mockWindowInsights);
 
   beforeEach(() => setTableInterceptors());
 

diff --git a/src/components/InventoryTabs/HybridInventoryTabs.cy.js b/src/components/InventoryTabs/HybridInventoryTabs.cy.js
@@ -37,7 +37,7 @@ const mountWithProps = (props) => {
 };
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 describe('When edge parity feature is enabled', () => {

diff --git a/src/routes/InventoryDetail.cy.js b/src/routes/InventoryDetail.cy.js
@@ -45,7 +45,7 @@ hostInGroup.results[0].groups = [
 hostInGroup.results[0].system_profile.operating_system.name = 'RHEL';
 
 describe('renders correctly', () => {
-  before(() => cy.mockWindowChrome());
+  before(() => cy.mockWindowInsights());
   beforeEach(() => prepareTest());
 
   it('renders main components for edge host', () => {
@@ -67,7 +67,7 @@ describe('renders correctly', () => {
 
 describe('rbac integration', () => {
   describe('with no permissions', () => {
-    before(() => cy.mockWindowChrome({ userPermissions: [] }));
+    before(() => cy.mockWindowInsights({ userPermissions: [] }));
     beforeEach(() => prepareTest(hostInGroup));
 
     it('should disable delete and edit buttons', () => {
@@ -90,7 +90,7 @@ describe('rbac integration', () => {
 
   describe('with write permissions limited by group', () => {
     before(() =>
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           {
             permission: 'inventory:hosts:write',
@@ -124,7 +124,7 @@ describe('rbac integration', () => {
 
   describe('with excluding group permissions', () => {
     before(() =>
-      cy.mockWindowChrome({
+      cy.mockWindowInsights({
         userPermissions: [
           {
             permission: 'inventory:hosts:write',

diff --git a/src/routes/InventoryTable.cy.js b/src/routes/InventoryTable.cy.js
@@ -44,7 +44,7 @@ const waitForTable = (waitNetwork = false) => {
 };
 
 before(() => {
-  cy.mockWindowChrome();
+  cy.mockWindowInsights();
 });
 
 describe('test data', () => {
@@ -235,7 +235,7 @@ describe('inventory table', () => {
   describe('integration with rbac', () => {
     describe('with only read permissions', () => {
       before(() => {
-        cy.mockWindowChrome({
+        cy.mockWindowInsights({
           userPermissions: ['inventory:*:read'],
         });
       });
@@ -273,7 +273,7 @@ describe('inventory table', () => {
 
     describe('with group-level hosts write permissions', () => {
       before(() => {
-        cy.mockWindowChrome({
+        cy.mockWindowInsights({
           userPermissions: [
             'inventory:*:read',
             {
@@ -352,7 +352,7 @@ describe('inventory table', () => {
 
     describe('with excluding group-level hosts write permissions', () => {
       before(() => {
-        cy.mockWindowChrome({
+        cy.mockWindowInsights({
           userPermissions: [
             'inventory:*:read',
             {
@@ -402,7 +402,7 @@ describe('inventory table', () => {
 
     describe('with limited groups write permissions', () => {
       before(() => {
-        cy.mockWindowChrome({
+        cy.mockWindowInsights({
           userPermissions: [
             'inventory:*:read',
             {