Re-allow "unknown" value for staleness filter (#1574)

RedHatInsights · Dec 6, 2023 · 586e0d7 · 586e0d7
1 parent 13f6f34
commit 586e0d7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/app/culling.py b/app/culling.py
@@ -85,5 +85,5 @@ def _culled_timestamp(self):
 
 def staleness_to_conditions(staleness, staleness_states, host_type, timestamp_filter_func):
     condition = Conditions(staleness, host_type)
-    filtered_states = (state for state in staleness_states)
+    filtered_states = (state for state in staleness_states if state != "unknown")
     return (timestamp_filter_func(*getattr(condition, state)(), host_type=host_type) for state in filtered_states)
diff --git a/swagger/api.spec.yaml b/swagger/api.spec.yaml
@@ -1156,6 +1156,7 @@ components:
             - fresh
             - stale
             - stale_warning
+            - unknown
         default:
           - fresh
           - stale
@@ -1173,6 +1174,7 @@ components:
             - fresh
             - stale
             - stale_warning
+            - unknown
       description: "Culling states of the hosts."
     tagsParam:
       name: tags

diff --git a/swagger/openapi.json b/swagger/openapi.json
@@ -1870,7 +1870,8 @@
             "enum": [
               "fresh",
               "stale",
-              "stale_warning"
+              "stale_warning",
+              "unknown"
             ]
           },
           "default": [
@@ -1892,7 +1893,8 @@
             "enum": [
               "fresh",
               "stale",
-              "stale_warning"
+              "stale_warning",
+              "unknown"
             ]
           }
         },

diff --git a/tests/test_xjoin.py b/tests/test_xjoin.py
@@ -768,7 +768,7 @@ def test_query_variables_staleness(
 
 
 def test_query_multiple_staleness(mocker, culling_datetime_mock, graphql_query_empty_response, api_get):
-    url = build_hosts_url(query="?staleness=fresh&staleness=stale_warning")
+    url = build_hosts_url(query="?staleness=fresh&staleness=stale_warning&staleness=unknown")
     response_status, response_data = api_get(url)
 
     assert response_status == 200