feat: Add spec ilab_model_list #4311
Open
+129
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiazhang <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4311 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 765 766 +1
Lines 41753 41774 +21
Branches 8815 8821 +6
=======================================
+ Hits 32221 32241 +20
Misses 8464 8464
- Partials 1068 1069 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
reviewed
Dec 18, 2024
| if line.startswith("|") and "Model Name" not in line: | ||
| split_items = line.split("|") | ||
| if len(split_items) == 5: | ||
| data.append( |
There was a problem hiding this comment.
nitpick, how about remove the local var data and append dict item to the list directly? e.g.
if len(split_items) == 5:
...
self.append(...)
else
raise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jiazhang [email protected]
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add this spec for a new Advisor rule