feat: enhance add_filter to support the max matched lines #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RHINENG-14668 for each filter, keep 10k matched lines by default for now. don't remove the "grep -F" as it's faster and can be used to reduce the file size before cleaning - Add test to verify the count of matched lines Move all spec relevant tests to tests/specs Move all core relevant tests to tests/core Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
- added a new keyword argument "max_match=MAX_MATCH" to `add_filter`. By declaring the max_match, at most `max_match` number of lines that contain the patterns will be filtered out in the collection. For redundant declarations the maximum `max_match` will be kept as the final scanning number. If no `max_match` is declared when `add_filter`, the filters.MAX_MATCH (=10000) will be take as the default value. - added a new keyword argument "with_matches=False" to the `get_filters`. When "with_matches=True" is specified, the return value of the `get_filters` will be dict in which the max scanning numbers for each filter pattern are included as the dict value. - update the exiting tests - RHINENG-14669 Signed-off-by: Xiangce Liu <[email protected]>
|
It depends on #4299. Please do not review it yet. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4303 +/- ##
==========================================
+ Coverage 77.18% 77.20% +0.02%
==========================================
Files 767 767
Lines 41762 41787 +25
Branches 8818 8827 +9
==========================================
+ Hits 32232 32262 +30
+ Misses 8462 8455 -7
- Partials 1068 1070 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_filter.By declaring the max_match, at most
max_matchnumber of lines thatcontain the patterns will be filtered out in the collection.
For redundant declarations the maximum
max_matchwill be kept as thefinal scanning number. If no
max_matchis declared whenadd_filter,the filters.MAX_MATCH (=10000) will be take as the default value.
get_filters.When "with_matches=True" is specified, the return value of the
get_filterswill be dict in which the max scanning numbers for eachfilter pattern are included as the dict value.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here