chore: refine the format of default_manifest in collect.py #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
force-pushed
the
collect_manifest
branch
from
bb9fa4b
to
004378f
Compare
xiangce
force-pushed
the
collect_manifest
branch
from
004378f
to
d9b296a
Compare
- reorder and regroup the 'configs' that should be loaded in collection - use the full path to the Class for each 'configs' - tapstop=2 for the inline YAML - replace Services combiner in datasources with UnitFiles Parser - and reorder python imports with pre-commit Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
xiangce
force-pushed
the
collect_manifest
branch
from
d9b296a
to
186fd28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4258 +/- ##
=======================================
Coverage 77.01% 77.01%
=======================================
Files 761 761
Lines 41464 41471 +7
Branches 8763 8763
=======================================
+ Hits 31932 31939 +7
Misses 8480 8480
Partials 1052 1052
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoySnow
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here