test: test_httpd_conf_files_main_miss failed when httpd.conf exists #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this test tried to verify that the httpd_conf cannot be collected when the main httpd.conf doesn't exist. However, when running test in a machine that have this httpd.conf in system already, it will fail. - this PR mocks the os.path.join and hence simulates that the main httpd.conf doesn't exist and ignore the facts - Jira: RHINENG-13664 Signed-off-by: Xiangce Liu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4257 +/- ##
==========================================
+ Coverage 76.94% 77.00% +0.05%
==========================================
Files 758 761 +3
Lines 41361 41464 +103
Branches 8734 8763 +29
==========================================
+ Hits 31826 31930 +104
+ Misses 8482 8481 -1
Partials 1053 1053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
changed the title
JoySnow
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpd_confcannot be collectedwhen the main httpd.conf doesn't exist. However, when running test
in a machine that have this httpd.conf in system already, it will fail.
os.path.joinand hence simulates that the mainhttpd.conf doesn't exist and ignore the facts
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here