Change sos archive lvm spec names #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trying to make the spec name more specific, I'm working adding tags to the sos project it was requested for a more specific spec/tag name. Signed-off-by: Ryan Blakley <[email protected]>
|
@ryan-blakley - This update looks good to me, but it would break the tests of some existing rules of insights-plugins and gss-rules, let's handle these tests first. It's easy to update the tests of gss-rules (I raised a MR for this), but it's a bit complex for insights-plugins, @wushiqinlou will handle them. I think we can merge it in the next cycle. |
|
@xiangce Sounds good whatever works best for y'all, there is no hurry to merge this. |
|
The related changes to the existing rules were done, I'm going to merge them together. |
xiangce
pushed a commit
that referenced
this pull request
Feb 6, 2023
* Trying to make the spec name more specific, I'm working adding tags to the sos project it was requested for a more specific spec/tag name. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 045878f)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Trying to make the spec name more specific, I'm working adding tags to the sos project it was requested for a more specific spec/tag name. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Trying to make the spec name more specific, I'm working adding tags to the sos project it was requested for a more specific spec/tag name.