Exclude malware-detection rules files in /var/tmp (and other locations) #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Customer confirmed that this patch fixed the problem for them, so it would be good to get this out as soon as we can. |
|
Thanks @ahitacat, how do I get this merged as neither of us have permissions to merge it :/ |
bfahr
approved these changes
Jan 25, 2023
bfahr
pushed a commit
that referenced
this pull request
Jan 25, 2023
…s) (#3665) Signed-off-by: Mark Huth <[email protected]> Signed-off-by: Mark Huth <[email protected]> (cherry picked from commit 08f423b)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
…s) (#3665) Signed-off-by: Mark Huth <[email protected]> Signed-off-by: Mark Huth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Huth [email protected]
All Pull Requests:
Check all that apply:
Customers who have /tmp linked to /var/tmp will get false positives from the downloaded rules file in /var/tmp because we only check for the rules file in /tmp. /facepalm ... D'oh ... crikey ... sheesh ... good lord .... Anyway, this PR makes sure we check /tmp, /var/tmp, /usr/tmp and tempfile.gettempdir() for the downloaded rules file so we can ignore it in all those locations.