Create timeout signal for hostcontext only #3647

lhuett · 2023-01-09T18:41:03Z

All Pull Requests:

Check all that apply:

Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
Is this PR to correct an issue?
Is this PR an enhancement?

Complete Description of Additions/Changes:

Since timeout signals are only needed when HostContext is used we only need to set the signal in that case, logic was change to skip when using any other context than Hostcontext.
Changes were made to the pytest module to add HostContext object to the broker in present tests
Additional pytests were added to test when not HostContext

xiangce · 2023-01-10T09:55:11Z

insights/core/plugins.py

@@ -99,8 +100,9 @@ def invoke(self, broker):
        # Grab the timeout from the decorator, or use the default of 120.
        self.timeout = getattr(self, "timeout", 120)

-        signal.signal(signal.SIGALRM, self._handle_timeout)
-        signal.alarm(self.timeout)
+        if HostContext in broker:


@lhuett - do you think it's reasonable to also move the definition of the self.timeout (L101) into the if clause? since it's only used in this case.

@xiangce Good point, I can do that.

* feat: Check if HostContext before setting signal in invoke(). * feat: Check if HostContext before setting signal in invoke(). * feat: Check if HostContext before setting signal in invoke(). Foxed flake8 issue * feat: Check if HostContext before setting signal in invoke(). Foxed move self.timeout set under check for HostContext Signed-off-by: lhuett <[email protected]> Signed-off-by: lhuett <[email protected]> (cherry picked from commit 944547c)

* feat: Check if HostContext before setting signal in invoke(). * feat: Check if HostContext before setting signal in invoke(). * feat: Check if HostContext before setting signal in invoke(). Foxed flake8 issue * feat: Check if HostContext before setting signal in invoke(). Foxed move self.timeout set under check for HostContext Signed-off-by: lhuett <[email protected]> Signed-off-by: lhuett <[email protected]>

lhuett changed the title ~~Signal hostcontext only~~ Create timeout signal for hostcontext only Jan 9, 2023

xiangce reviewed Jan 10, 2023

View reviewed changes

lhuett force-pushed the signal_hostcontext_only branch from d6d0211 to 49b2430 Compare January 10, 2023 19:07

bfahr merged commit 944547c into master Jan 10, 2023

xiangce deleted the signal_hostcontext_only branch January 11, 2023 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create timeout signal for hostcontext only #3647

Create timeout signal for hostcontext only #3647

lhuett commented Jan 9, 2023

xiangce Jan 10, 2023

lhuett Jan 10, 2023

Create timeout signal for hostcontext only #3647

Create timeout signal for hostcontext only #3647

Conversation

lhuett commented Jan 9, 2023

All Pull Requests:

Complete Description of Additions/Changes:

xiangce Jan 10, 2023

Choose a reason for hiding this comment

lhuett Jan 10, 2023

Choose a reason for hiding this comment