feat: Add env override to CommandOutputProvider #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiangce Not sure if this is the best method, but this change fixes the issue mentioned in bz 2091084, and possibly the others related to character issues. |
xiangce
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
@ryan-blakley - I think this is a good workaround to the character issue and thanks for adding the interface to override the default evn.
* Added the ability to override env variables in CommandOutputProvider for specs, along with updating each function that inherited from CommandOutputProvider. * Added an override for the yum repolist command to unset the LC_ALL env variable. * Fixed an issue where self.create_env() was being called multiple times instead of once. * Fixed some pep issues. Signed-off-by: Ryan Blakley <[email protected]>
bfahr
pushed a commit
that referenced
this pull request
Jan 10, 2023
* Added the ability to override env variables in CommandOutputProvider for specs, along with updating each function that inherited from CommandOutputProvider. * Added an override for the yum repolist command to unset the LC_ALL env variable. * Fixed an issue where self.create_env() was being called multiple times instead of once. * Fixed some pep issues. Signed-off-by: Ryan Blakley <[email protected]> Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 555963c)
3 tasks
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Added the ability to override env variables in CommandOutputProvider for specs, along with updating each function that inherited from CommandOutputProvider. * Added an override for the yum repolist command to unset the LC_ALL env variable. * Fixed an issue where self.create_env() was being called multiple times instead of once. * Fixed some pep issues. Signed-off-by: Ryan Blakley <[email protected]> Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Added the ability to override env variables in CommandOutputProvider for specs, along with updating each function that inherited from CommandOutputProvider. Added an override for the yum command to unset the LC_ALL env variable. Fixed an issue where self.create_env() was being called multiple times instead of once. Fixed some pep issues.