fix: Do not log Parsers' Traceback during collection #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
force-pushed
the
parser_exception_during_collection
branch
from
7645550 to
c26121e
Compare
|
@ryan-blakley - I just rebased this PR from the latest moving of exceptions, please kindly review. |
|
@ryan-blakley - as this is a small change and we have talked about it in the last sync, after @chenlizhong 's approval, I'd like to merge and release it today. Thanks. |
xiangce
added a commit
that referenced
this pull request
Jan 12, 2023
* fix: Do not log Parsers' Traceback during collection Signed-off-by: Xiangce Liu <[email protected]> * fix doc error by renaming Signed-off-by: Xiangce Liu <[email protected]> * resolve rebase conflict * revert blank line Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit a1b573f)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
* fix: Do not log Parsers' Traceback during collection Signed-off-by: Xiangce Liu <[email protected]> * fix doc error by renaming Signed-off-by: Xiangce Liu <[email protected]> * resolve rebase conflict * revert blank line Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This PR doesn't resolve the character issue in the 2 BZs but just hides the detailed Traceback info in the log.