Improve old Python compatibility by not requiring ipython 8.6.0. #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ryan-blakley
approved these changes
Dec 14, 2022
xiangce
pushed a commit
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Jakub Svoboda <[email protected]> (cherry picked from commit d7af213)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Jakub Svoboda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakub Svoboda [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The pinned version of ipython is not compatible with Python 3.6. The pinning makes running pip install -e ".[develop]" impossible. As a result, setting up a fresh development environment with old Python is impossible without removing the pin. The pin was introduced in #3615.