Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old malware rules files from /var/tmp as well #3625

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

mhuth
Copy link
Contributor

@mhuth mhuth commented Dec 12, 2022

Signed-off-by: Mark Huth [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Some customers have /var/tmp instead of /tmp and unfortunately the logic for deleting old malware rules files fails in that case. This PR adds /var/tmp as a location to try deleting old rules files from. Why do we want to delete old malware rules files ... because they cause false positives in matching systems.

@mhuth mhuth requested a review from xiangce December 12, 2022 21:42
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me

@xiangce xiangce merged commit 2d26b20 into master Dec 13, 2022
@xiangce xiangce deleted the malware_detection_old_rules_path branch December 13, 2022 03:32
xiangce pushed a commit that referenced this pull request Dec 13, 2022
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants