Keep the code to delete previously-named malware rules file #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
pushed a commit
that referenced
this pull request
Dec 1, 2022
- just in case the previously-named rules file isn't deleted for some reason Signed-off-by: Mark Huth <[email protected]> (cherry picked from commit b6e75ab)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
- just in case the previously-named rules file isn't deleted for some reason Signed-off-by: Mark Huth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Huth [email protected]
All Pull Requests:
Check all that apply:
Just some small changes to some recent malware-detection commits I made. Main one was making sure the old downloaded rules file is still deleted. I've renamed the file, but its possible (although rare) that the old file could be maintained on the customer's system and isn't deleted as we've changed the file name now that we are deleting. This commit makes sure the old file name is still deleted as well.