Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add spec sys_cpuset_cpus #3611

Merged
merged 5 commits into from
Dec 7, 2022
Merged

feat: Add spec sys_cpuset_cpus #3611

merged 5 commits into from
Dec 7, 2022

Conversation

wushiqinlou
Copy link
Contributor

@wushiqinlou wushiqinlou commented Nov 25, 2022

Signed-off-by: jiazhang [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This spec is used to add container check on one insights-plugins advisor rule

@wushiqinlou wushiqinlou changed the title Add spec sys_cpuset_cpus feat: Add spec sys_cpuset_cpus Nov 25, 2022
@xiangce
Copy link
Contributor

xiangce commented Nov 29, 2022

This PR seems to be duplicated with the #3612

@wushiqinlou wushiqinlou changed the title feat: Add spec sys_cpuset_cpus [DRAFT]feat: Add spec sys_cpuset_cpus Nov 29, 2022
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
@wushiqinlou wushiqinlou changed the title [DRAFT]feat: Add spec sys_cpuset_cpus feat: Add spec sys_cpuset_cpus Nov 30, 2022
@wushiqinlou
Copy link
Contributor Author

@xiangce - Please reivew.

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me

@xiangce xiangce requested a review from ryan-blakley December 5, 2022 08:47
insights/tests/parsers/test_cpuset_cpus.py Outdated Show resolved Hide resolved
insights/parsers/cpuset_cpus.py Outdated Show resolved Hide resolved
Signed-off-by: jiazhang <[email protected]>
Copy link
Contributor

@ryan-blakley ryan-blakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@xiangce xiangce merged commit b8db8b0 into RedHatInsights:master Dec 7, 2022
xiangce pushed a commit that referenced this pull request Dec 7, 2022
* Add spec sys_cpuset_cpus

Signed-off-by: jiazhang <[email protected]>

* Update spec name
* Update style
* Update import format

Signed-off-by: jiazhang <[email protected]>
(cherry picked from commit b8db8b0)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Add spec sys_cpuset_cpus

Signed-off-by: jiazhang <[email protected]>

* Update spec name
* Update style
* Update import format

Signed-off-by: jiazhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants