fix: fix errors in ethtool #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psachin
reviewed
Nov 23, 2022
|
@psachin @xiangce @ryan-blakley
|
chenlizhong
force-pushed
the
fix_bug_ethtool
branch
from
498ec00 to
2e345ea
Compare
psachin
approved these changes
Nov 25, 2022
ryan-blakley
requested changes
Nov 28, 2022
chenlizhong
force-pushed
the
fix_bug_ethtool
branch
from
e6447ab to
156d9c5
Compare
xiangce
approved these changes
Dec 1, 2022
xiangce
pushed a commit
that referenced
this pull request
Dec 7, 2022
* fix: fix 'invalid literal for int() with base 10: n/a' error and 'bad line' parse exception in ethtool Signed-off-by: Chen lizhong <[email protected]> * test: fix flake8 error in test file Signed-off-by: Chen lizhong <[email protected]> * test: Remove print in test file Signed-off-by: Chen lizhong <[email protected]> * test: update test for n/a checking Signed-off-by: Chen lizhong <[email protected]> * fix: use isnumeric() method instead of 'n/a in value' Signed-off-by: Chen lizhong <[email protected]> * fix: support python3 and python2 both for isnumeric() Signed-off-by: Chen lizhong <[email protected]> * fix: fix flake8 Signed-off-by: Chen lizhong <[email protected]> * fix: fix error in python2.6 Signed-off-by: Chen lizhong <[email protected]> (cherry picked from commit 9ed8f4a)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: fix 'invalid literal for int() with base 10: n/a' error and 'bad line' parse exception in ethtool Signed-off-by: Chen lizhong <[email protected]> * test: fix flake8 error in test file Signed-off-by: Chen lizhong <[email protected]> * test: Remove print in test file Signed-off-by: Chen lizhong <[email protected]> * test: update test for n/a checking Signed-off-by: Chen lizhong <[email protected]> * fix: use isnumeric() method instead of 'n/a in value' Signed-off-by: Chen lizhong <[email protected]> * fix: support python3 and python2 both for isnumeric() Signed-off-by: Chen lizhong <[email protected]> * fix: fix flake8 Signed-off-by: Chen lizhong <[email protected]> * fix: fix error in python2.6 Signed-off-by: Chen lizhong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen lizhong [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Fix errors:
insights.parsers.ethtool.CoalescingInfo ValueError("invalid literal for int() with base 10: 'n/a'")
insights.parsers.ethtool.TimeStamp ParseException('bad line: \tsoftware-receive')
insights.parsers.ethtool.TimeStamp ParseException('bad line: \thardware-transmit')
insights.parsers.ethtool.Ring ValueError("invalid literal for int() with base 10: 'n/a'"