feat: Add timeout to datasources #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
reviewed
Nov 17, 2022
* Added timeout using signals in the datasource invoke function, when the timeout is hit it raises a TimeoutException. * Added code in the dehydrate to properly dehydrate caught exceptions, and simplified it to be more readable. Signed-off-by: Ryan Blakley <[email protected]>
bfahr
approved these changes
Dec 1, 2022
bfahr
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Added timeout using signals in the datasource invoke function, when the timeout is hit it raises a TimeoutException. * Added code in the dehydrate to properly dehydrate caught exceptions, and simplified it to be more readable. Signed-off-by: Ryan Blakley <[email protected]> Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit ff98e30)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Added timeout using signals in the datasource invoke function, when the timeout is hit it raises a TimeoutException. * Added code in the dehydrate to properly dehydrate caught exceptions, and simplified it to be more readable. Signed-off-by: Ryan Blakley <[email protected]> Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Added timeout using signals in the datasource invoke function, when the timeout is hit it raises a TimeoutException. Added code in the dehydrate to properly dehydrate caught exceptions.