Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New specs var_log_pcp_openmetrics_log #3596

Merged
merged 0 commits into from
Nov 22, 2022
Merged

New specs var_log_pcp_openmetrics_log #3596

merged 0 commits into from
Nov 22, 2022

Conversation

mohitkumarrh
Copy link
Contributor

@mohitkumarrh mohitkumarrh commented Nov 16, 2022

Signed-off-by: Mohit Kumar [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

@mohitkumarrh
Copy link
Contributor Author

py.test:

➜  insights-core git:(specs_var_log_pcp_openmetrics_log) ✗ py.test -svk pcp_openmetrics_log --cov=insights.parsers.pcp_openmetrics_log
=========================================================================== test session starts ===========================================================================
platform darwin -- Python 3.9.1, pytest-7.1.2, pluggy-1.0.0 -- /Users/mohitkumar/.pyenv/versions/3.9.1/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/mohitkumar/Insights/insights-core, configfile: setup.cfg, testpaths: insights
plugins: cov-3.0.0
collecting 186 items                                                                                                                                                      Downloading a fresh and hot uploader.json...
collected 2942 items / 2940 deselected / 2 selected                                                                                                                       

insights/tests/parsers/test_pcp_openmetrics_log.py::test_pcp_openmetrics_log PASSED
insights/tests/parsers/test_pcp_openmetrics_log.py::test_documentation PASSED

---------- coverage: platform darwin, python 3.9.1-final-0 -----------
Name                                      Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------
insights/parsers/pcp_openmetrics_log.py       5      0      2      0   100%
-------------------------------------------------------------------------------------
TOTAL                                         5      0      2      0   100%


=================================================================== 2 passed, 2940 deselected in 6.71s ====================================================================

@psachin psachin added the FILTER Change Change requires update of the uploader.json on the insights-core-assets project label Nov 16, 2022
@mohitkumarrh
Copy link
Contributor Author

@xiangce @psachin please review

@psachin
Copy link
Contributor

psachin commented Nov 16, 2022

@mohitkumarrh Looks good to me.

@psachin
Copy link
Contributor

psachin commented Nov 16, 2022

/ Pending specs approval /

@mohitkumarrh

This comment was marked as off-topic.

@xiangce xiangce merged commit 04ddde3 into RedHatInsights:master Nov 22, 2022
xiangce pushed a commit that referenced this pull request Nov 22, 2022
Signed-off-by: Mohit Kumar <[email protected]>
(cherry picked from commit 04ddde3)
@mohitkumarrh mohitkumarrh deleted the specs_var_log_pcp_openmetrics_log branch November 22, 2022 10:18
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FILTER Change Change requires update of the uploader.json on the insights-core-assets project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants