Handle network exceptions when accessing egg URL #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuth
force-pushed
the
more_network_exception_handling
branch
from
e98d594 to
5dc955f
Compare
xiangce
added
the
client
|
@xiangce are you able to merge this for me please? I don't have permission to do so. |
xiangce
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Mark Huth <[email protected]> (cherry picked from commit 0a0753d)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Mark Huth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Huth [email protected]
All Pull Requests:
Check all that apply:
This PR is for more gracefully handling network exceptions if there is a problem accessing/downloading the egg URL. Its to better handle the error shown in https://bugzilla.redhat.com/show_bug.cgi?id=2107323. It doesn't actually have anything to do with retrying downloads because --retry only applies to uploads.
Logs before PR (unhandled exceptions and tracebacks):
Logs after PR (helpful error messages and graceful failure):
