Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: New Parser for 'dotnet --version' Command for Containers #3581

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Feat: New Parser for 'dotnet --version' Command for Containers #3581

merged 6 commits into from
Nov 9, 2022

Conversation

TZ3070
Copy link
Contributor

@TZ3070 TZ3070 commented Nov 4, 2022

Signed-off-by: Xinting Li [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

New parser for dotnet --version in container

Xinting Li added 2 commits November 4, 2022 16:08
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please update the git commit msg more relevant.

insights/parsers/dotnet.py Outdated Show resolved Hide resolved
Xinting Li added 2 commits November 8, 2022 09:39
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
@TZ3070 TZ3070 changed the title Feat: New Parser for 'dotnet --version' Command Feat: New Parser for 'dotnet --version' Command for Containers Nov 8, 2022
Signed-off-by: Xinting Li <[email protected]>
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the approval of the Spec

Signed-off-by: Xinting Li <[email protected]>
@xiangce xiangce merged commit ce50be2 into RedHatInsights:master Nov 9, 2022
xiangce pushed a commit that referenced this pull request Nov 10, 2022
* Feat: New Parser for 'dotnet --version' Command

Signed-off-by: Xinting Li <[email protected]>

* Update spec
* Fix Parser Name
* Update Doc string
* Update doc title
* Add doctest

Signed-off-by: Xinting Li <[email protected]>
(cherry picked from commit ce50be2)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Feat: New Parser for 'dotnet --version' Command

Signed-off-by: Xinting Li <[email protected]>

* Update spec
* Fix Parser Name
* Update Doc string
* Update doc title
* Add doctest

Signed-off-by: Xinting Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants