fix: let container_execute to support rpm_format of installed_rpms #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
changed the title
xiangce
changed the title
xiangce
force-pushed
the
enhance_container_specs
branch
from
3d1a343 to
140e570
Compare
|
@xiangce everything looks good, but is there a way to possibly add a test for this? |
ryan-blakley
approved these changes
Oct 21, 2022
|
@ryan-blakley - Thank you very much for reviewing. But you remind me that I forgot to add tests for these specs that I recently added. I raised PR #3563 to add the tests for them. Please have a look too. |
xiangce
added a commit
that referenced
this pull request
Oct 24, 2022
…3559) * feat: make container_execute to support rpm_format of installed_rpms - and update the insights/util/autology/datasources.py correspondingly Signed-off-by: Xiangce Liu <[email protected]> * only one path can be passed once Signed-off-by: Xiangce Liu <[email protected]> * update the logic more clear Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 3b812c9)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
…3559) * feat: make container_execute to support rpm_format of installed_rpms - and update the insights/util/autology/datasources.py correspondingly Signed-off-by: Xiangce Liu <[email protected]> * only one path can be passed once Signed-off-by: Xiangce Liu <[email protected]> * update the logic more clear Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The
rpm_formatofinstalled_rpmsincludes%characters, which caused thecollect_executecannot collect it from the container correctly.insights-core/insights/core/spec_factory.py
Line 1011 in 1880a9c
This patch fixes this issue with:
the_cmd = "/usr/bin/%s exec %s %s" % (engine, cid, cmd)