Handle upload exceptions allowing --retries to work properly #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mhuth
added
the
client
|
Logs with --retries 3 and network exceptions (disabled the NIC in the VM): |
mhuth
force-pushed
the
network_exceptions_retries_take2
branch
from
596e6c1 to
93b141e
Compare
ahitacat
reviewed
Oct 20, 2022
ahitacat
reviewed
Oct 20, 2022
mhuth
force-pushed
the
network_exceptions_retries_take2
branch
2 times, most recently
from
89a8fe7 to
4048c28
Compare
Thanks for the review/approval @ahitacat . Unfortunately I don't have permissions to merge this PR. Are you able to do that? Thanks. |
No, I don't have that power |
xiangce
pushed a commit
that referenced
this pull request
Oct 25, 2022
Signed-off-by: Mark Huth <[email protected]> (cherry picked from commit d0dc83c)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Mark Huth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Huth [email protected]
All Pull Requests:
Check all that apply:
This is to fix https://bugzilla.redhat.com/show_bug.cgi?id=2117686
The insights-core connection.py._http_request() code doesn't handle network exceptions. Callers of this function just get status_codes containing errors rather than any network exception handling. This PR catches network exceptions in the _http_request() method and raises them up the call stack until they are caught in the client.py.upload() and _legacy_upload() functions. This allows the --retries option to work correctly because before, --retries didn't work if there was a network exception.