Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new spec and parser for 'subscription-manage facts' #3555

Merged
merged 0 commits into from
Nov 3, 2022
Merged

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Oct 17, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

New spec and parser for subscription-manager facts.

  • Will implement a combiner CloudInstance once other specs related to cloud instance are finished.

@xiangce xiangce marked this pull request as ready for review October 27, 2022 02:57
@xiangce xiangce requested a review from psachin November 1, 2022 04:00
@psachin psachin merged commit 4ac809a into master Nov 3, 2022
@xiangce xiangce deleted the rhsm_facts branch November 3, 2022 05:40
psachin pushed a commit that referenced this pull request Nov 3, 2022
* feat: new spec and parser for 'subscription-manage facts'

Signed-off-by: Xiangce Liu <[email protected]>

* add fixed filter

Signed-off-by: Xiangce Liu <[email protected]>

* miss the filterable=True

Signed-off-by: Xiangce Liu <[email protected]>

* use ': ' as the separator instead of ':'

Signed-off-by: Xiangce Liu <[email protected]>

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 4ac809a)
xiangce added a commit that referenced this pull request Sep 6, 2024
* feat: new spec and parser for 'subscription-manage facts'

Signed-off-by: Xiangce Liu <[email protected]>

* add fixed filter

Signed-off-by: Xiangce Liu <[email protected]>

* miss the filterable=True

Signed-off-by: Xiangce Liu <[email protected]>

* use ': ' as the separator instead of ':'

Signed-off-by: Xiangce Liu <[email protected]>

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants