Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: New parser for the "ls -lan /var/lib/sss/pubconf/krb5.include.d" command #3545

Merged
merged 0 commits into from
Oct 13, 2022
Merged

Feat: New parser for the "ls -lan /var/lib/sss/pubconf/krb5.include.d" command #3545

merged 0 commits into from
Oct 13, 2022

Conversation

rasrivas-redhat
Copy link
Contributor

Signed-off-by: Rahul Srivastava [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This is a new parser request to list all the files present in the /var/lib/sss/pubconf/krb5.include.d directory.

@rasrivas-redhat rasrivas-redhat changed the title New parser ls_krb5_sssd Feat: New parser for the "ls -lan /var/lib/sss/pubconf/krb5.include.d" command Oct 11, 2022
@@ -336,6 +336,7 @@ class DefaultSpecs(Specs):
ls_etc = simple_command("/bin/ls -lan {0}".format(' '.join(etc_and_sub_dirs)), keep_rc=True)
ls_etc_ssh = simple_command("/bin/ls -lanL /etc/ssh")
ls_ipa_idoverride_memberof = simple_command("/bin/ls -lan /usr/share/ipa/ui/js/plugins/idoverride-memberof")
ls_krb5_sssd = simple_command("/bin/ls -lan /var/lib/sss/pubconf/krb5.include.d")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rasrivas-redhat please add the file spec to insights/specs/insights_archive.py so that the spec collected via JSON can be accessed from the archive. Use the mangle command to determine what file path to use.

Copy link
Contributor Author

@rasrivas-redhat rasrivas-redhat Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bfahr - Thanks for noticing it, added a related spec to insights/specs/insights_archive.py

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the approval of spec

@xiangce xiangce merged commit 379d2c2 into RedHatInsights:master Oct 13, 2022
@rasrivas-redhat rasrivas-redhat deleted the new_parser_ls_krb5_sssd branch October 13, 2022 05:40
xiangce pushed a commit that referenced this pull request Oct 13, 2022
…" command (#3545)

* New parser ls_krb5_sssd

Signed-off-by: Rahul Srivastava <[email protected]>

* Added ls_krb5_sssd spec to insights_archive.py

Signed-off-by: Rahul Srivastava <[email protected]>
(cherry picked from commit 379d2c2)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
…" command (#3545)

* New parser ls_krb5_sssd

Signed-off-by: Rahul Srivastava <[email protected]>

* Added ls_krb5_sssd spec to insights_archive.py

Signed-off-by: Rahul Srivastava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants