Avoid test to write in disk if machine-id is not found #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahitacat <[email protected]>
vdymna
added
the
client
|
LGTM too. |
strider
approved these changes
Oct 20, 2022
xiangce
pushed a commit
that referenced
this pull request
Oct 27, 2022
Signed-off-by: ahitacat <[email protected]> (cherry picked from commit 468c6b4)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: ahitacat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahitacat [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Malware test was trying to create a
machine-idfile if there isn't one in the system.I have mocked the method that tries to create the machine-id as a solution.